Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC of AIP-69 - A first task can be called remote #40224

Closed
wants to merge 37 commits into from

Conversation

jscheffl
Copy link
Contributor

This PR is a DRAFT to further discuss technical details on AIP-69 direction. DO NOT MERGE - but please feedback on it.

Please treat this as a PoC, it is only partly working. It can be used to distribute the first task but a lot of core required functions to make a MVP are missing. Status of implementation is tracked in airflow/providers/remote/TODO.md in this PR.

If you want to test it you can:

  • Checkout the branch
  • Run breeze start-airflow --python 3.12 --load-example-dags --backend postgres --executor RemoteExecutor --answer y
  • Start the Remote executor with airflow/providers/remote/_start_remote_worker.sh
  • A (non templated, not mapped, non failing) task can be run, e.g. use example DAG example_python_operator. Wohoo!
    image
  • If you open the UI you will see an additional plugin loaded in the menu "Admin" -> "Remote Worker Status":
    image

Based on progress and time I will sometimes rebase and push changes to this branch. But it will not be something that will be review-able.
I will not add any migration logic in case of updates for the additional tables in DB Scheme. If I update the draft PR and DB schema changes, DB might need to be reset. Of course migration support would need to be added before a "real" release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This change is needed allowing to re-route the Internal API calls to another endpoint (Assuming: Remote Worker API should be HTTPS (not HTTP) and needs to be exposed Internet-Facing. (App GW, Protection different than internal API)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporary script for development testing to start the remote worker.

Note that mainly it is used to drop all DB connection information to ensure that all backend calls must be made via HTTP API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This extension is needed to allow new Pydantic class mappings from Remote Provider Package to be registered - allowing to leverage AIP-44 RPC call logic with non-code model classes

@jscheffl jscheffl force-pushed the feature/aip-69-poc branch 3 times, most recently from 10c46e6 to 9ec0db9 Compare June 22, 2024 12:53
@jscheffl jscheffl force-pushed the feature/aip-69-poc branch 2 times, most recently from 6d3960c to a676ff3 Compare June 24, 2024 18:46
@jscheffl jscheffl force-pushed the feature/aip-69-poc branch from a676ff3 to 2c177c4 Compare June 25, 2024 20:01
@jscheffl jscheffl force-pushed the feature/aip-69-poc branch from 2c177c4 to b435658 Compare June 28, 2024 06:13
@jscheffl jscheffl force-pushed the feature/aip-69-poc branch 5 times, most recently from 732068b to 92e171f Compare July 10, 2024 21:18
@jscheffl jscheffl force-pushed the feature/aip-69-poc branch 6 times, most recently from e77da34 to 1e51a55 Compare July 17, 2024 20:09
@jscheffl jscheffl added this to the Airflow 2.10.0 milestone Jul 17, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 11, 2024
@jscheffl
Copy link
Contributor Author

Yeah, cool. Stale... but code "almost" is on main... closing but keeping as reference of progress.

@jscheffl jscheffl closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-69 Edge Executor area:dev-tools area:Executors-core LocalExecutor & SequentialExecutor area:providers area:serialization stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants