-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC of AIP-69 - A first task can be called remote #40224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change is needed allowing to re-route the Internal API calls to another endpoint (Assuming: Remote Worker API should be HTTPS (not HTTP) and needs to be exposed Internet-Facing. (App GW, Protection different than internal API)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary script for development testing to start the remote worker.
Note that mainly it is used to drop all DB connection information to ensure that all backend calls must be made via HTTP API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This extension is needed to allow new Pydantic class mappings from Remote Provider Package to be registered - allowing to leverage AIP-44 RPC call logic with non-code model classes
10c46e6
to
9ec0db9
Compare
6d3960c
to
a676ff3
Compare
a676ff3
to
2c177c4
Compare
2c177c4
to
b435658
Compare
732068b
to
92e171f
Compare
e77da34
to
1e51a55
Compare
9b004a8
to
15c3dc4
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Yeah, cool. Stale... but code "almost" is on main... closing but keeping as reference of progress. |
This PR is a DRAFT to further discuss technical details on AIP-69 direction. DO NOT MERGE - but please feedback on it.
Please treat this as a PoC, it is only partly working. It can be used to distribute the first task but a lot of core required functions to make a MVP are missing. Status of implementation is tracked in
airflow/providers/remote/TODO.md
in this PR.If you want to test it you can:
breeze start-airflow --python 3.12 --load-example-dags --backend postgres --executor RemoteExecutor --answer y
airflow/providers/remote/_start_remote_worker.sh
example_python_operator
. Wohoo!Based on progress and time I will sometimes rebase and push changes to this branch. But it will not be something that will be review-able.
I will not add any migration logic in case of updates for the additional tables in DB Scheme. If I update the draft PR and DB schema changes, DB might need to be reset. Of course migration support would need to be added before a "real" release.