-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): allow valueFrom in env config of components (#40095) #40135
feat(chart): allow valueFrom in env config of components (#40095) #40135
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Could you please add a unit test for it ( |
Oh sure sorry totally missed that one 🙈 |
1666c0d
to
2055bb4
Compare
done
done thanks @potiuk and @jedcunningham and sorry for the delay |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @dada-engineer! Congrats on your first commit 🎉 |
This fixes #40095 and allows the users of the official helm chart to add a valueFrom specification (for secret and configmap references) to the env config of components (most of them use the
container_extra_env
functions defined in _helpers.yaml).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.