-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-2951] Update dag_run table end_date when state change #3990
Merged
ashb
merged 1 commit into
apache:v1-10-test
from
YingboWang:cherry-pick-fix-dagrun-no-end-date
Oct 3, 2018
Merged
[AIRFLOW-2951] Update dag_run table end_date when state change #3990
ashb
merged 1 commit into
apache:v1-10-test
from
YingboWang:cherry-pick-fix-dagrun-no-end-date
Oct 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing airflow only change dag_run table end_date value when a user teminate a dag in web UI. The end_date will not be updated if airflow detected a dag finished and updated its state. This commit add end_date update in DagRun's set_state function to make up tho problem mentioned above.
Codecov Report
@@ Coverage Diff @@
## v1-10-test #3990 +/- ##
==============================================
+ Coverage 77.77% 77.78% +<.01%
==============================================
Files 203 203
Lines 15306 15307 +1
==============================================
+ Hits 11904 11906 +2
+ Misses 3402 3401 -1
Continue to review full report at Codecov.
|
Thanks @YingboWang |
👍 LGTM |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Oct 22, 2018
…e#3990) The existing airflow only change dag_run table end_date value when a user teminate a dag in web UI. The end_date will not be updated if airflow detected a dag finished and updated its state. This commit add end_date update in DagRun's set_state function to make up tho problem mentioned above.
galak75
pushed a commit
to VilledeMontreal/incubator-airflow
that referenced
this pull request
Nov 23, 2018
…e#3990) The existing airflow only change dag_run table end_date value when a user teminate a dag in web UI. The end_date will not be updated if airflow detected a dag finished and updated its state. This commit add end_date update in DagRun's set_state function to make up tho problem mentioned above.
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Jan 23, 2019
The existing airflow only change dag_run table end_date value when a user teminate a dag in web UI. The end_date will not be updated if airflow detected a dag finished and updated its state. This commit add end_date update in DagRun's set_state function to make up tho problem mentioned above.
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 22, 2019
…low#3990 GitOrigin-RevId: bf860a29a3d2bb25900fc36c6888f3a833830575
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 22, 2019
…che/airflow#3990" This reverts commit bf860a29a3d2bb25900fc36c6888f3a833830575. Change-Id: I417cccf213cb62d6051a6fb7f74ed7ee91b56485 GitOrigin-RevId: f5532d76f2c791fb58521f6046150f48f4f3d909
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Apr 11, 2020
…low#3990 GitOrigin-RevId: bf860a29a3d2bb25900fc36c6888f3a833830575
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Apr 11, 2020
…che/airflow#3990" This reverts commit bf860a29a3d2bb25900fc36c6888f3a833830575. Change-Id: I417cccf213cb62d6051a6fb7f74ed7ee91b56485 GitOrigin-RevId: f5532d76f2c791fb58521f6046150f48f4f3d909
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 16, 2021
…low#3990 GitOrigin-RevId: bf860a29a3d2bb25900fc36c6888f3a833830575
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 16, 2021
…che/airflow#3990" This reverts commit bf860a29a3d2bb25900fc36c6888f3a833830575. Change-Id: I417cccf213cb62d6051a6fb7f74ed7ee91b56485 GitOrigin-RevId: f5532d76f2c791fb58521f6046150f48f4f3d909
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 23, 2021
…low#3990 GitOrigin-RevId: bf860a29a3d2bb25900fc36c6888f3a833830575
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 23, 2021
…che/airflow#3990" This reverts commit bf860a29a3d2bb25900fc36c6888f3a833830575. Change-Id: I417cccf213cb62d6051a6fb7f74ed7ee91b56485 GitOrigin-RevId: f5532d76f2c791fb58521f6046150f48f4f3d909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing airflow only change dag_run table end_date value when
a user teminate a dag in web UI. The end_date will not be updated
if airflow detected a dag finished and updated its state.
This commit add end_date update in DagRun's set_state function to
make up tho problem mentioned above.
Make sure you have checked all steps below.
Jira
Description
Same feature was merged in master before. This PR is to backport to v1-10-test
Tests
tests/models.py:DagRunTest.test_dagrun_set_state_end_date
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff
@ashb @KevinYang21