Apply PROVIDE_PROJECT_ID mypy workaround across Google provider #39129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:logging
area:providers
provider:cncf-kubernetes
|
cc: @VladaZakharova |
|
cc: @moiseenkov |
potiuk
force-pushed
the
apply-project-id-workaround
branch
from
ec62247
to
e42f8aa
Compare
moiseenkov
approved these changes
Apr 19, 2024
potiuk
added
upgrade to newer dependencies
There is a simple workaround implemented several years ago for Google provider `project_id` default value being PROVIDE_PROJECT_ID that satisfy mypy checks for project_id being set. They way how `fallback_to_default_project_id` works is that across all the providers the project_id is actually set, even if technically it's default value is set to None. This is similar typing workaround as we use for NEW_SESSION in the core of Airflow. The workaround has not been applied consistently across all the google provider code and occasionally it causes MyPy complaining when newer version of a google library introduces more strict type checking and expects the provider_id to be set. This PR applies the workaround across all the Google provider code. This is - generally speaking a no-op operation. Nothing changes, except MyPy being aware that the project_id is actually going to be set even if it is technically set to None.
potiuk
force-pushed
the
apply-project-id-workaround
branch
from
e42f8aa
to
5d1b885
Compare
|
Rerunning with upgrade + full tests needed just in case. |
pankajkoti
approved these changes
Apr 19, 2024
Lee-W
approved these changes
Apr 19, 2024
|
Random /flaky failure . Merging. All looks good. In the future (providing we keep the approach) it should not cause unexpected mypy issues. |
potiuk
added a commit
that referenced
this pull request
Apr 19, 2024
There is a simple workaround implemented several years ago for Google provider `project_id` default value being PROVIDE_PROJECT_ID that satisfy mypy checks for project_id being set. They way how `fallback_to_default_project_id` works is that across all the providers the project_id is actually set, even if technically it's default value is set to None. This is similar typing workaround as we use for NEW_SESSION in the core of Airflow. The workaround has not been applied consistently across all the google provider code and occasionally it causes MyPy complaining when newer version of a google library introduces more strict type checking and expects the provider_id to be set. This PR applies the workaround across all the Google provider code. This is - generally speaking a no-op operation. Nothing changes, except MyPy being aware that the project_id is actually going to be set even if it is technically set to None. (cherry picked from commit 90acbfb)
potiuk
added
the
changelog:skip
|
cc: @ephraimbuddy @jedcunningham -> I cherry-picked that one to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a simple workaround implemented several years ago for Google provider
project_iddefault value being PROVIDE_PROJECT_ID that satisfy mypy checks for project_id being set. They way howfallback_to_default_project_idworks is that across all the providers the project_id is actually set, even if technically it's default value is set to None.This is similar typing workaround as we use for NEW_SESSION in the core of Airflow.
The workaround has not been applied consistently across all the google provider code and occasionally it causes MyPy complaining when newer version of a google library introduces more strict type checking and expects the provider_id to be set.
This PR applies the workaround across all the Google provider code.
This is - generally speaking a no-op operation. Nothing changes, except MyPy being aware that the project_id is actually going to be set even if it is technically set to None.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.