-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] raise exception with main notebook error in DatabricksRunNowDeferrableOperator #39110
[FEAT] raise exception with main notebook error in DatabricksRunNowDeferrableOperator #39110
Conversation
541bedc
to
bd6e798
Compare
@Lee-W changes are done, please review and let me know |
Hi @Lee-W , is there any issue with PR |
1f6af3b
to
747a1f9
Compare
747a1f9
to
ab91c88
Compare
1a5445f
to
d8c2ba1
Compare
d8c2ba1
to
f406db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @pankajkoti , can you please review |
I think we're good to merge this one. Just want to see whether @pankajkoti have some time to double check if I missed anything. I'm going to merge this later today. Please let me know if anyone want to take a deeper look. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the PR title and description by taking hints from https://cbea.ms/git-commit/ or something similar to mention what and why we're doing.
Also the would be nice in general for PR title to be in imperative mood like mentioned in https://cbea.ms/git-commit/#imperative
7158a46
to
1c0709b
Compare
1c0709b
to
805544c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nitpick. But I'm good with this PR now 👍 @pankajkoti could you please take another look? Thanks!
I added my concern here #39110 (comment). But leave the decision to you @Lee-W :) |
f3f7e8b
to
3f6d898
Compare
@Lee-W @pankajkoti please review, deferrable changes done as per review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Lee-W @pankajkoti , raised PR for runnow operator separately as discussed, please review #39354 |
Thanks for your prompt implementation! Will look into it today |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.