fix: add retry logic in case of google auth refresh credential error #38961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
dondaum
force-pushed
the
fix/google-bigquery-refresh-error
branch
from
98933d1 to
0f506dd
Compare
Lee-W
reviewed
Apr 16, 2024
dondaum
force-pushed
the
fix/google-bigquery-refresh-error
branch
2 times, most recently
from
899a981 to
ea616c4
Compare
Lee-W
approved these changes
Apr 16, 2024
shahar1
approved these changes
Apr 20, 2024
|
I'm planning on merging this one later today. Please let me know if anyone wants to take a deeper look 🙂 |
eladkal
approved these changes
Apr 21, 2024
eladkal
force-pushed
the
fix/google-bigquery-refresh-error
branch
from
ea616c4 to
0e8566c
Compare
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, acquire impersonated credentials can fail with a 502 HTTP (Server error). It raises a
google.auth.exceptions.RefreshError. Using task retries is sometimes not a good option as, e.g. a submitted BigQuey query should not be submitted again.The error occur in tasks running in deferred mode where acquiring impersonated credentials happens frequently every x seconds depending on the task's poll_interval.
In this case we should have some retry to acquire impersonated credentials.
Note: The deferable version of
BigQueryInsertJobOperatoris using the the synchronous client call with the event loop's run_in_executor() method. #35833closes: #38532
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.