Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly select task in DAG Graph View when clicking on its name #38782

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Correctly select task in DAG Graph View when clicking on its name #38782

merged 8 commits into from
Oct 2, 2024

Conversation

jonhspyro
Copy link
Contributor

Allowed taskName component to be clickable

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 5, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Apr 5, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@uranusjr uranusjr changed the title Fix in DAG Graph View, clicking Task on it's name doesn't select the task Correctly select task in DAG Graph View when clicking on its name Apr 8, 2024
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 25, 2024
@jonhspyro jonhspyro requested a review from bbovenzi May 25, 2024 18:31
jonhspyro
jonhspyro commented May 26, 2024
View reviewed changes
Copy link
Contributor Author

@jonhspyro jonhspyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

airflow/www/static/js/dag/details/graph/DagNode.tsx Show resolved Hide resolved
@jscheffl jscheffl added this to the Airflow 2.9.2 milestone May 31, 2024
jscheffl
jscheffl approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small formatting-glitch (indent is wrong, static check hit the wall) - can you correct? Then we could merge it. Rebase on fix would also be great.

@jonhspyro jonhspyro requested a review from bbovenzi June 2, 2024 18:29
@jscheffl
Copy link
Contributor

jscheffl commented Jun 2, 2024

Still there are some static checks. Can you fix them? Maybe you can also run them locally via pre-commit.

@jonhspyro jonhspyro requested a review from jscheffl June 19, 2024 12:04
@jscheffl jscheffl removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 19, 2024
@pedro-cf
Copy link

Greetings since @jonhspyro is MIA, is there any way to continue with this merge?

@pedro-cf pedro-cf mentioned this pull request Sep 15, 2024
Closed
2 tasks
@jscheffl
Copy link
Contributor

Greetings since @jonhspyro is MIA, is there any way to continue with this merge?

I think if @pedro-cf is MIA... can you follow-up and clean the branch in another fork? Then we could merge. But seems some un-related changes are still there besides a conflict...

@pedro-cf
Copy link

pedro-cf commented Sep 15, 2024 •
edited
Loading

I think if @pedro-cf is MIA... can you follow-up and clean the branch in another fork? Then we could merge. But seems some un-related changes are still there besides a conflict...

I've never contributed PRs to airflow sorry, was just hoping this could be merged somehow.

bbovenzi
bbovenzi approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the user_command changes. lgtm

@bbovenzi bbovenzi merged commit f826659 into apache:main Oct 2, 2024
52 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 2, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@bbovenzi bbovenzi mentioned this pull request Oct 3, 2024
Merged
bbovenzi added a commit to astronomer/airflow that referenced this pull request Oct 3, 2024
@jonhspyro @bbovenzi
Correctly select task in DAG Graph View when clicking on its name (ap…
0341a21 
…ache#38782)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (apache#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: Brent Bovenzi <[email protected]>
pierrejeambrun pushed a commit that referenced this pull request Oct 3, 2024
@bbovenzi @jonhspyro
Correctly select task in DAG Graph View when clicking on its name (#3…
b9069e7 
…8782) (#42697)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: jonhspyro <[email protected]>
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@jonhspyro @bbovenzi @joaopamaral
Correctly select task in DAG Graph View when clicking on its name (ap…
a12d78c 
…ache#38782)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (apache#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: Brent Bovenzi <[email protected]>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Oct 23, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 23, 2024
@bbovenzi @jonhspyro @utkarsharma2
Correctly select task in DAG Graph View when clicking on its name (#3…
d1eeae0 
…8782) (#42697)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: jonhspyro <[email protected]>
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
@bbovenzi @jonhspyro @utkarsharma2
Correctly select task in DAG Graph View when clicking on its name (#3…
7f6b556 
…8782) (#42697)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: jonhspyro <[email protected]>
This was referenced Oct 28, 2024
Closed
Closed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@jonhspyro @bbovenzi @ellisms
Correctly select task in DAG Graph View when clicking on its name (ap…
a28665a 
…ache#38782)

* Fix in DAG Graph View, clicking Task on it's name doesn't select the task. (apache#37932)

* Updated TaskName onClick

* Fixed missing onToggleCollapse

* Added missing changes

* Updated: rebase

* fixed providers error message

* undo fab changes

* Update user_command.py

---------

Co-authored-by: Brent Bovenzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.10.3
Development

Successfully merging this pull request may close these issues.
6 participants
@jonhspyro @jscheffl @pedro-cf @bbovenzi @ephraimbuddy @utkarsharma2