Pass through more parameters to AzureBlobFileSystem to mirror handlin… #38747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
tomrutter
force-pushed
the
microsoft_azure_blob_storage_allow_managed_identity_objectstore
branch
from
1c695ab
to
9e07242
Compare
tomrutter
force-pushed
the
microsoft_azure_blob_storage_allow_managed_identity_objectstore
branch
from
9e07242
to
7379f26
Compare
|
unit tests? |
|
I've updated the code and added some unit tests. I've also updated the handling a little to handle more than just the specific use case I need right now. The intention is to bring the way that |
tomrutter
force-pushed
the
microsoft_azure_blob_storage_allow_managed_identity_objectstore
branch
from
dfa9482
to
998f8aa
Compare
|
Checked tests and linting pass, and rebased to latest main. |
|
Tests failing, I am afraid. |
…and add unit tests. fix tests that were missed by keeping path of the account_url unchanged.
tomrutter
force-pushed
the
microsoft_azure_blob_storage_allow_managed_identity_objectstore
branch
from
998f8aa
to
8bf3cb7
Compare
|
Apologies, I realised too late that I missed the "db tests". Should all be ok now? |
potiuk
approved these changes
Apr 12, 2024
|
Thanks! |
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a few extra parameters through from connection extras to
adlfs.AzureBlobFileSystemto mirror handling of connection inWasbHook:managed_identity_client_idworkload_identity_tenant_idanoncloses: #38746
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.