-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator #38716
Conversation
…amRunPythonPipelineOperator
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add unit test. bug fix must be covered by test to avoid regression
6c8ca7b
to
3036c0e
Compare
…nPipelineOperator to ensure that GCSHook is only called when necessary
…ok 'gs://' arg prefixes
Static checks need fixing. |
@potiuk Static checks should pass now. I sincerely apologize for that, I'll ensure to run pre-commit checks for any future contributions. |
Nothing to be sorry about :) |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This resolves #38713 by modifying BeamRunPythonPipelineOperator.execute_sync() to only call GCSHook when necessary
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.