Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to correct GCSHook being called even when not required with BeamRunPythonPipelineOperator #38716

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

zstrathe
Copy link
Contributor

@zstrathe zstrathe commented Apr 3, 2024

This resolves #38713 by modifying BeamRunPythonPipelineOperator.execute_sync() to only call GCSHook when necessary


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Apr 3, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add unit test. bug fix must be covered by test to avoid regression

…nPipelineOperator to ensure that GCSHook is only called when necessary
@e-galan
Copy link
Contributor

e-galan commented Apr 18, 2024

The changes look good to me @zstrathe. What do you think @eladkal ?

@potiuk
Copy link
Member

potiuk commented Apr 18, 2024

Static checks need fixing.

@zstrathe
Copy link
Contributor Author

@potiuk Static checks should pass now. I sincerely apologize for that, I'll ensure to run pre-commit checks for any future contributions.

@potiuk
Copy link
Member

potiuk commented Apr 19, 2024

Nothing to be sorry about :)

@potiuk potiuk merged commit fd8a057 into apache:main Apr 19, 2024
41 checks passed
Copy link

boring-cyborg bot commented Apr 19, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeamRunPythonPipelineOperator: cannot run local input files with DirectRunner
4 participants