Improve stability of remove_task_decorator function #38649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
approved these changes
Apr 1, 2024
jscheffl
added
the
area:core-operators
|
Thanks for reviving this old PR, I totally forgot about it but I'm glad to see that its back up for review 🙌 FWIW I still think that this is an imperfect solution (and anything which relies on manipulating code as a plain string probably will be), but it should at least fix the reported error without introducing new failures. See additional notes in #34509. |
eladkal
approved these changes
Apr 1, 2024
I only fixed a small test, the credits goes to @SamWheating |
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Improve stability of remove_task_decorator function * fix statics * test * remove test --------- Co-authored-by: Sam Wheating <[email protected]> (cherry picked from commit f1301da)
ephraimbuddy
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Improve stability of remove_task_decorator function * fix statics * test * remove test --------- Co-authored-by: Sam Wheating <[email protected]> (cherry picked from commit f1301da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #34154
cc: @SamWheating
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.