-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Delete deprecated AutoML operators and deprecate AutoML hook and links (#38418)" #38633
Conversation
I assume this is due to #38418 (comment) ? Can you please clarify what APIs are not going to be useful after Mar 31? Because if the APIs are not useful we don't need to revert |
Yes, the following APIs won't be available after Mar 31: AutoML Tables, AutoML Video Intelligence, AutoML Vision and AutoML NLP. |
tests are failing due to merging #38504 |
3a47977
to
b435116
Compare
cc @potiuk I am not sure how we can workaround the error build? |
Hello @shahar1, Thank you for this PR and the previous PR. I tried to use the revert button for the previous PR but it did not work. When I create the community PR (to this repo), I will ask a review from you @shahar1 |
Hey, there was a conflict due to changes of dependcies handling in |
Hey @shahar1, Thank you again for your effort and struggles for this matter; very appreciated.
Yes, I know I created the PR in Vlada's fork 😅 It was my fault for not mentioning the WIP PR. Sorry for the miscommunication. Btw, I created the new PR: #38673
If we can do this, it will be wonderful because for the PR I tried to comply with the Airflow Deprecation Policy.
Also, we will continue to support most of the operators (at least for the next major version of the package) due to the deprecation policy. They will definitely fail and we will raise an exception for the users who are using the operators but it needs to be there. Hence we cannot remove the system tests. Also, the main idea of the new PR is finding alternatives/replacements of the operators for the deprecated services instead of just removing them. To summarize the current situation,
|
…and links (apache#38418)" This reverts commit 4a4eee1
This reverts commit 4a4eee1 (#38418).
As @molcay stated in #38418, the operators and hook may still be useful for AutoML Translation, which I overlooked when working on the PR above.
I'll create another PR to delete specific ops. and hooks that become unusable and to convert some deprecation warnings to exceptions.
I'll try to be more careful on similar occasions.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.