-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deferrable mode for Custom Training Job operators #38584
Merged
Lee-W
merged 1 commit into
apache:main
from
VladaZakharova:add-defer-mode-to-custom-training-job-operators
Apr 11, 2024
Merged
Deferrable mode for Custom Training Job operators #38584
Lee-W
merged 1 commit into
apache:main
from
VladaZakharova:add-defer-mode-to-custom-training-job-operators
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:google
Google (including GCP) related issues
labels
Mar 28, 2024
Lee-W
reviewed
Apr 4, 2024
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
from
April 4, 2024 10:33
cdba3ae
to
fd8d26e
Compare
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
2 times, most recently
from
April 4, 2024 12:52
62877c7
to
ce47e26
Compare
potiuk
approved these changes
Apr 7, 2024
Lee-W
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nitpicks. But overall looks good to me!
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
3 times, most recently
from
April 9, 2024 20:58
8ca1e8e
to
cd4e7f7
Compare
e-galan
force-pushed
the
add-defer-mode-to-custom-training-job-operators
branch
from
April 10, 2024 08:10
cd4e7f7
to
fbb0d89
Compare
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
area:system-tests
kind:documentation
provider:google
Google (including GCP) related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the deferrable mode feature for the following Vertex AI operators:
Other changes include:
VertexAIModelLink
. The old link url did not work anymore, I replaced it with a working one.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.