Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade FAB to 4.4.1 #38319

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Upgrade FAB to 4.4.1 #38319

merged 1 commit into from
Mar 20, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 20, 2024

This upgrades FAB to version 4.4.1 and brings all the changes done to security manager between v4.3.11 and v4.4.1. As usual we need to manually synchronize the changes to security manager which we override in FAB provider.

This one also has the nice effect of bumping limits for a number of dependencies we have, such as Werkzeug (finally <4 rather than <3) and Flask (<3 rather than <2.3).

Still SQLAlchemy is not bumped though.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Mar 20, 2024

I'd really appreciate verifying if I applied all the changes between v4.3.11 and v4.4.1 that we should incorporate in our override @vincbeck especially - but also others.

@potiuk potiuk force-pushed the upgrade-fab-to-4.4.1 branch from 106306e to 09bfaac Compare March 20, 2024 10:12
@potiuk potiuk requested a review from ashb as a code owner March 20, 2024 10:12
@potiuk potiuk force-pushed the upgrade-fab-to-4.4.1 branch from 09bfaac to 7991e6a Compare March 20, 2024 10:57
@potiuk potiuk requested a review from pierrejeambrun as a code owner March 20, 2024 10:57
@potiuk potiuk force-pushed the upgrade-fab-to-4.4.1 branch from 7991e6a to 1ae27f0 Compare March 20, 2024 11:53
This upgrades FAB to version 4.4.1 and brings all the changes done
to security manager between v4.3.11 and v4.4.1. As usual we need
to manually synchronize the changes to security manager which we
override in FAB provider.

This one also has the nice effect of bumping limits for a number of
dependencies we have, such as Werkzeug (finally <4 rather than <3)
and Flask (<3 rather than <2.3).

Still SQLAlchemy is not bumped though.
@potiuk potiuk force-pushed the upgrade-fab-to-4.4.1 branch from 1ae27f0 to 4a785c5 Compare March 20, 2024 12:40
@vincbeck
Copy link
Contributor

I checked the diff between FAB 4.3.11 and 4.4.1 and I dont think you forgot anything 👌

@potiuk potiuk merged commit 7776e91 into apache:main Mar 20, 2024
88 checks passed
@potiuk potiuk deleted the upgrade-fab-to-4.4.1 branch March 20, 2024 14:06
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:fab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants