-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade FAB to 4.4.1 #38319
Merged
Merged
Upgrade FAB to 4.4.1 #38319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd really appreciate verifying if I applied all the changes between v4.3.11 and v4.4.1 that we should incorporate in our override @vincbeck especially - but also others. |
106306e
to
09bfaac
Compare
09bfaac
to
7991e6a
Compare
potiuk
commented
Mar 20, 2024
potiuk
commented
Mar 20, 2024
7991e6a
to
1ae27f0
Compare
This upgrades FAB to version 4.4.1 and brings all the changes done to security manager between v4.3.11 and v4.4.1. As usual we need to manually synchronize the changes to security manager which we override in FAB provider. This one also has the nice effect of bumping limits for a number of dependencies we have, such as Werkzeug (finally <4 rather than <3) and Flask (<3 rather than <2.3). Still SQLAlchemy is not bumped though.
1ae27f0
to
4a785c5
Compare
vincbeck
reviewed
Mar 20, 2024
I checked the diff between FAB 4.3.11 and 4.4.1 and I dont think you forgot anything 👌 |
vincbeck
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
provider:fab
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades FAB to version 4.4.1 and brings all the changes done to security manager between v4.3.11 and v4.4.1. As usual we need to manually synchronize the changes to security manager which we override in FAB provider.
This one also has the nice effect of bumping limits for a number of dependencies we have, such as Werkzeug (finally <4 rather than <3) and Flask (<3 rather than <2.3).
Still SQLAlchemy is not bumped though.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.