-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MSGraphOperator in Microsoft Azure provider #38111
Conversation
This reverts commit 693975e.
You should remove your fix and rebase - in change you applied you removed the markers on tests but it needs |
…s a db test" This reverts commit c7a06db.
So I need to do like this then? Not completely understanding what you meant (I reverted my fix containing the db markers on the test-methods):
|
See how it it's done in main (and you rebased to it) |
Ok then I don't understand why sometimes it's still failing, it's not alway the case as on some python version it succeeds but on others not |
Those are new tests you addded that are now failing, It's a different error you get: You also need to mark the test as db_test per instruction:
Now why they are not failing in 3.10+ I am not sure - maybe your tests follow different path on those python versions without trying to access DB ? |
Hmm those tests are not new, the only new one is the TestMSGraphSensor and that one doesn't fail apparently. Weird... |
some main errrs fixed already - you will need to rebase |
The docker example error workarounded in main. Merging |
Thank you @potiuk :) |
As already discussed before I did a proposition to add the MS Graph Operator. After discussion on the airflow dev list we came to an agreement that the operator could be added as part of the Microsoft Azure provider. This is my initial commit so any suggestions are welcome, I still need to add examples and propably need to update some docstrings but this PR can already give an idea of what will be added. I already created a PR so I can see what comes out of the Airflow QA.
In the meantime, our article on how we use the operator at Infrabel has been published on the Apache Airflow medium:
https://medium.com/apache-airflow/optimizing-integration-with-the-ms-graph-api-and-power-bi-with-the-msgraphasyncoperator-in-airflow-d1071f7c1b62
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.