Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubeconform pre-commit #37920

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 5, 2024

Fixes: #37919


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Mar 5, 2024

Before the fix from #37917

Screenshot 2024-03-06 at 00 16 27

After the fix:

Screenshot 2024-03-06 at 00 17 12

@potiuk
Copy link
Member Author

potiuk commented Mar 6, 2024

Failing tests fixed in #37923

@potiuk potiuk merged commit 4770854 into apache:main Mar 6, 2024
87 of 99 checks passed
@potiuk potiuk deleted the add-kubeconform-precommit branch March 6, 2024 00:26
@utkarsharma2 utkarsharma2 added this to the Airflow 2.8.3 milestone Mar 6, 2024
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 6, 2024
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Mar 6, 2024
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.8.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run helm chart through kubeconform -strict as part of the CI process
4 participants