-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the deferrable mode to the Dataflow sensors #37693
Add the deferrable mode to the Dataflow sensors #37693
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
a3a6ca4
to
77f2ac0
Compare
77f2ac0
to
b3597f7
Compare
Hi @eladkal @Lee-W @hussein-awala ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet finish the whole reviewing. left a few nitpicks
ffe164a
to
a6f89fc
Compare
DataflowJobAutoScalingEventsSensor
and DataflowJobMessagesSensor
.a6f89fc
to
661ff82
Compare
661ff82
to
f3c2714
Compare
f3c2714
to
d2290e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me. One last nitpick.
d2290e6
to
6222d42
Compare
Add the deferrable mode for the Dataflow sensors.
Changes:
DataflowJobAutoScalingEventTrigger
,DataflowJobStatusTrigger
,DataflowJobMetricsTrigger
andDataflowJobMessagesTrigger
;AsyncDataflowHook
;^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.