-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing informative logs in KPO trigger until container has not finished #37546
Merged
pankajkoti
merged 2 commits into
apache:main
from
astronomer:kpo-triggerer-progress-log
Apr 24, 2024
Merged
Add missing informative logs in KPO trigger until container has not finished #37546
pankajkoti
merged 2 commits into
apache:main
from
astronomer:kpo-triggerer-progress-log
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
requested review from
jedcunningham and
hussein-awala
as code owners
February 19, 2024 13:59
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
labels
Feb 19, 2024
16 tasks
pankajkoti
changed the title
Add informative logs in KPO trigger until container has not finished
Add missing informative logs in KPO trigger until container has not finished
Feb 19, 2024
eladkal
reviewed
Feb 19, 2024
pankajastro
reviewed
Feb 19, 2024
pankajastro
approved these changes
Feb 19, 2024
dirrao
reviewed
Feb 20, 2024
pankajkoti
commented
Feb 20, 2024
amoghrajesh
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One super nit, otherwise LGTM
eladkal
approved these changes
Mar 9, 2024
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Stale PRs per the .github/workflows/stale.yml policy file
label
Apr 24, 2024
hussein-awala
approved these changes
Apr 24, 2024
pankajkoti
force-pushed
the
kpo-triggerer-progress-log
branch
from
April 24, 2024 06:52
6d04baf
to
87ee37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
stale
Stale PRs per the .github/workflows/stale.yml policy file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.