Fix intermittent failures coming from buildkit parallel builds #37403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PROD cachie build often fails (especially in v2-8-test) when it tries to rebuild the PROD cache in parallel on ARM. There is some weird inter-buildx problem with it and some people experience it sometimes as documented in moby/buildkit#2367 Instead of finding the root cause, we change this specific job in CI to run sequentially. This changes the time it will take to update cache - but not as much as 4x because the builds do not parallelise very well anyway. Likely instead of 8m we will get maybe total 15m, and since this is just cache update after everything else has completed, it does not matter too much if it runs a little longer.
potiuk
requested review from
jedcunningham,
hussein-awala,
Taragolis and
pankajkoti
hussein-awala
approved these changes
Feb 13, 2024
potiuk
deleted the
fix-intermittent-failures-for-parallel-prod-cache-build
branch
potiuk
added a commit
that referenced
this pull request
Feb 13, 2024
The PROD cachie build often fails (especially in v2-8-test) when it tries to rebuild the PROD cache in parallel on ARM. There is some weird inter-buildx problem with it and some people experience it sometimes as documented in moby/buildkit#2367 Instead of finding the root cause, we change this specific job in CI to run sequentially. This changes the time it will take to update cache - but not as much as 4x because the builds do not parallelise very well anyway. Likely instead of 8m we will get maybe total 15m, and since this is just cache update after everything else has completed, it does not matter too much if it runs a little longer. (cherry picked from commit 7a1c600)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
The PROD cachie build often fails (especially in v2-8-test) when it tries to rebuild the PROD cache in parallel on ARM. There is some weird inter-buildx problem with it and some people experience it sometimes as documented in moby/buildkit#2367 Instead of finding the root cause, we change this specific job in CI to run sequentially. This changes the time it will take to update cache - but not as much as 4x because the builds do not parallelise very well anyway. Likely instead of 8m we will get maybe total 15m, and since this is just cache update after everything else has completed, it does not matter too much if it runs a little longer. (cherry picked from commit 7a1c600)
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PROD cachie build often fails (especially in v2-8-test) when it tries to rebuild the PROD cache in parallel on ARM. There is some weird inter-buildx problem with it and some people experience it sometimes as documented in moby/buildkit#2367
Instead of finding the root cause, we change this specific job in CI to run sequentially. This changes the time it will take to update cache - but not as much as 4x because the builds do not parallelise very well anyway. Likely instead of 8m we will get maybe total 15m, and since this is just cache update after everything else has completed, it does not matter too much if it runs a little longer.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.