The "upgrade-on-failure" feature enabled by default in local environment #37116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have the `--upgrade-on-failure` flag that was used to automatically upgrade image when constraint build failed. This happens when there is a conflicting change merged, but the CI build has not managed yet to refresh the constraints (which sometime might take some time due to stability of our CI infrastructure - any intermittent failures in tests might delay constraint refreshing). What happens in this case, locally when you build image you would get dependency conflict. This PR flips the flag in local environmment in two cases: * when you run `breeze ci-image build` manually * when you run CI image build automatically while running other command On CI we want to keep control over constraint use, so the flag default is set to False in CI environment
potiuk
force-pushed
the
upgrade-depenendencies-on-failure-enabled-by-default
branch
from
1f44ced to
925f923
Compare
Taragolis
reviewed
Jan 31, 2024
Co-authored-by: Andrey Anshin <[email protected]>
Taragolis
approved these changes
Jan 31, 2024
potiuk
deleted the
upgrade-depenendencies-on-failure-enabled-by-default
branch
potiuk
added a commit
that referenced
this pull request
Feb 7, 2024
…ent (#37116) * The "upgrade-on-failure" feature enabled by default in local environment We have the `--upgrade-on-failure` flag that was used to automatically upgrade image when constraint build failed. This happens when there is a conflicting change merged, but the CI build has not managed yet to refresh the constraints (which sometime might take some time due to stability of our CI infrastructure - any intermittent failures in tests might delay constraint refreshing). What happens in this case, locally when you build image you would get dependency conflict. This PR flips the flag in local environmment in two cases: * when you run `breeze ci-image build` manually * when you run CI image build automatically while running other command On CI we want to keep control over constraint use, so the flag default is set to False in CI environment * Update dev/breeze/src/airflow_breeze/commands/ci_image_commands.py Co-authored-by: Andrey Anshin <[email protected]> --------- Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit a0f8a00)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
…ent (#37116) * The "upgrade-on-failure" feature enabled by default in local environment We have the `--upgrade-on-failure` flag that was used to automatically upgrade image when constraint build failed. This happens when there is a conflicting change merged, but the CI build has not managed yet to refresh the constraints (which sometime might take some time due to stability of our CI infrastructure - any intermittent failures in tests might delay constraint refreshing). What happens in this case, locally when you build image you would get dependency conflict. This PR flips the flag in local environmment in two cases: * when you run `breeze ci-image build` manually * when you run CI image build automatically while running other command On CI we want to keep control over constraint use, so the flag default is set to False in CI environment * Update dev/breeze/src/airflow_breeze/commands/ci_image_commands.py Co-authored-by: Andrey Anshin <[email protected]> --------- Co-authored-by: Andrey Anshin <[email protected]> (cherry picked from commit a0f8a00)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the
--upgrade-on-failureflag that was used to automatically upgrade image when constraint build failed. This happens when there is a conflicting change merged, but the CI build has not managed yet to refresh the constraints (which sometime might take some time due to stability of our CI infrastructure - any intermittent failures in tests might delay constraint refreshing).What happens in this case, locally when you build image you would get dependency conflict.
This PR flips the flag in local environmment in two cases:
breeze ci-image buildmanuallyOn CI we want to keep control over constraint use, so the flag default is set to False in CI environment
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.