Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location requirement in DataflowTemplatedJobStartOperator #37069

Conversation

shardbread
Copy link
Contributor

An error was encountered when calling the execute method on a DataflowTemplateJobStartOperator instance with an unspecified location.
This fix resolves the issue with an empty location in the execute method by setting the default value.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jan 29, 2024
@shardbread shardbread force-pushed the fix-set-default-value-for-location-in-DataflowTemplatedJobStartOperator-execute-method branch from f6624ec to 1a2f9f5 Compare February 2, 2024 09:42
@VladaZakharova
Copy link
Contributor

Hi @dirrao @potiuk !
Can you please check the changes here? Thank you!

@potiuk potiuk merged commit 1fe8cdd into apache:main Feb 5, 2024
56 checks passed
Copy link

boring-cyborg bot commented Feb 5, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants