Fix google operators handling of impersonation chain #36903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 19, 2024 14:55
The operator already accepts `impersonation_chain`, but does not pass it to the GCSHook.
…DataTrigger The operator already accepts `impersonation_chain`, but does not pass it to the BigQueryGetDataTrigger.
…nsertJobTrigger The operator already accepts `impersonation_chain`, but does not pass it to the BigQueryInsertJobTrigger.
…tJobTrigger The operator already accepts `impersonation_chain`, but does not pass it to the BigQueryInsertJobTrigger.
…tJobTrigger The operator already accepts `impersonation_chain`, but does not pass it to the BigQueryInsertJobTrigger.
boring-cyborg
bot
added
area:providers
provider:google
Lee-W
approved these changes
Jan 22, 2024
phanikumv
requested review from
pankajastro,
pankajkoti,
ephraimbuddy,
utkarsharma2 and
sunank200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the following operators
pass the existing argument
impersonation_chainon to the corresponding hooks and triggers.Note, in order for impersonation chain to take effect in
BigQueryInsertJobTriggerandBigQueryGetDataTriggerwe depend on #36849 to be merged, which will enable impersonation for asynchronous tasks.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.