Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check query status before SnowflakeSqlApiOperator execute in deferrable mode #36850

Conversation

vatsrahul1001
Copy link
Collaborator

This PR addresses checking the status of the query before deferring the task to the triggerer.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Jan 17, 2024
@vatsrahul1001 vatsrahul1001 marked this pull request as draft January 17, 2024 18:14
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Snowflake test cases are failing. Can you check and fix them?

@vatsrahul1001
Copy link
Collaborator Author

Nice work. Snowflake test cases are failing. Can you check and fix them?

fixed

@phanikumv phanikumv force-pushed the check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode branch from c12079c to bdc42e0 Compare January 18, 2024 06:26
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review January 18, 2024 06:37
@vatsrahul1001 vatsrahul1001 force-pushed the check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode branch from bdc42e0 to e3a4a20 Compare January 18, 2024 12:03
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phanikumv phanikumv merged commit 27dc7e8 into apache:main Jan 18, 2024
54 checks passed
@phanikumv phanikumv deleted the check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode branch January 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants