-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stacklevel in warnings.warn into the providers #36831
Conversation
9f3cb1f
to
43915a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I was wondering if there is a way to somehow automate it - or maybe just flag and require to make a deliberate decision when you reais exception in the provider?
Missing stacklevel=1 in most cases it useless level, because it point to exact place where it raised rather than where it called. We could add B028 to ruff config as soon as we resolve this PR, #36834 and make changes in core |
During check warnings which generated in our CI I've found that time to time we use
stacklevel=1
or even do not define it at all. This make it harder to find where actual call is happen.There is rule
B028
exists into theruff
for validate missingstacklevel
into the code, however nothing it could do with explicitstacklevel=1
There is additional changes exists in warnings, which I point into the separate discussions
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.