Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openlineage support for CopyFromExternalStageToSnowflakeOperator #36535

Conversation

kacpermuda
Copy link
Contributor

This PR adds support for Openlineage in CopyFromExternalStageToSnowflakeOperator.

I had a few different ideas (DESCRIBE STAGE, DESCRIBE TABLE etc.) about how to get some additional information about the files that are loaded and snowflake table itself, but this relying on the output of the query is the only one i came up with that does not require any additional Snowflake permissions apart from what You need to perform COPY INTO operation.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Jan 2, 2024
@kacpermuda
Copy link
Contributor Author

Also adding @mobuchowski

@kacpermuda kacpermuda force-pushed the openlineage/add-snowflake-external-stage-operator branch from f36a85d to 6ca2185 Compare January 3, 2024 10:28
@mobuchowski mobuchowski self-requested a review January 5, 2024 09:33
@kacpermuda kacpermuda marked this pull request as draft January 5, 2024 09:46
@kacpermuda kacpermuda force-pushed the openlineage/add-snowflake-external-stage-operator branch from 6ca2185 to da1bafb Compare January 8, 2024 09:30
@kacpermuda kacpermuda marked this pull request as ready for review January 8, 2024 09:33
Copy link
Contributor

@mobuchowski mobuchowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might want to add comment to one nit.

@mobuchowski mobuchowski merged commit 3dc99d8 into apache:main Jan 8, 2024
52 checks passed
@kacpermuda kacpermuda deleted the openlineage/add-snowflake-external-stage-operator branch January 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants