-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explanation about cleaning logs with helm #35783
Conversation
If you are deploying Airflow with Helm Chart this setting won't work. Instead, you should | ||
enable ``logGroomerSidecar``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also got it when using Elasticsearch remote logging. We need to be sure this happens also in the other technologies. Maybe @hussein-awala who wrote this feature #29772 can help us to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hussein-awala any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it should work with helm chart deployments too, I will take a look.
I also got it when using Elasticsearch remote logging.
You faced the issue with helm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes when deployed with helm the delete_local_logs
flag had no effect.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
cc @dstandish @jedcunningham I don't know if what I say here is 100% true but enabling
delete_local_logs
just didn't do anything for me when I deploy Airflow with helm (logs are stored on pvc)