Consolidate the warning stacklevel in KubernetesPodTrigger #35079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anukrati1507
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
amoghrajesh
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Changes look good to me +1. Let us wait for the CI
@hussein-awala WDYT?
amoghrajesh
reviewed
Oct 20, 2023
anukrati1507
force-pushed
the
issue34424
branch
from
55ac3e9 to
029b079
Compare
hussein-awala
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
LGTM
I recommend reading https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst for the next contributions.
uranusjr
approved these changes
Oct 23, 2023
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used stacklevel 2 instead of the default 1 in
Closes: #34424
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.