Use cached_property for hook in SparkKubernetesSensor
#34106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-fell
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Best practice to is make constructors of operators/sensors as simple as possible. Currently this sensor directly builds a KubernetesHook object in its construction. Yes, there are db or external calls when building the hook object itself, but: 1. if this hook changes for any reason, these types calls might sneak in 2. doesn't allow for templating of `kubernetes_conn_id` as brought up in [Airflow Slack](https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1693904864661079)
josh-fell
force-pushed
the
sparkkubernetes-sensor
branch
from
4cf264e to
b50c4cf
Compare
josh-fell
commented
Sep 5, 2023
| @@ -552,13 +552,6 @@ | |||
| class TestSparkKubernetesSensor: | |||
| def setup_method(self): | |||
| db.merge_conn(Connection(conn_id="kubernetes_default", conn_type="kubernetes", extra=json.dumps({}))) | |||
| db.merge_conn( | |||
There was a problem hiding this comment.
Completely duplicated line so I removed it.
Taragolis
approved these changes
Sep 5, 2023
jedcunningham
approved these changes
Sep 5, 2023
Lee-W
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice to is make constructors of operators/sensors as simple as possible. Currently this sensor directly builds a KubernetesHook object in its construction. Yes, there are db or external calls when building the hook object itself, but:
kubernetes_conn_idas brought up in Airflow Slack