Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add scheduler name to PODs templates #33843

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

wolvery
Copy link
Contributor

@wolvery wolvery commented Aug 28, 2023

This feature aims to enable the possibility to define a SchedulerName different than "Default".

With this feature, we are able to define some particular schedulers from Kubernetes to apply some different strategies to allocate resources.

More info in this link: https://kubernetes.io/docs/tasks/extend-kubernetes/configure-multiple-schedulers/

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Aug 28, 2023
@wolvery wolvery changed the title Chart: Add missing scheduler name to PODs Chart: Add scheduler name to PODs templates Aug 28, 2023
@wolvery wolvery force-pushed the feature/add-scheduler-name branch 2 times, most recently from 1cac8b2 to 04be06e Compare August 31, 2023 14:11
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for each deployment?

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Can you add some unit test coverage for this?

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolvery wolvery force-pushed the feature/add-scheduler-name branch from c83fa81 to b8b193d Compare September 8, 2023 12:52
@jedcunningham jedcunningham merged commit 8f5c65a into apache:main Sep 8, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants