Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers/microsoft): add DefaultAzureCredential support to AzureContainerVolumeHook #33822

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 28, 2023


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch 2 times, most recently from f32193a to 00519c3 Compare August 28, 2023 15:00
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch 2 times, most recently from d455d74 to 3461ab3 Compare August 29, 2023 02:23
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch from 2d7d893 to a231293 Compare August 29, 2023 09:20
@Lee-W
Copy link
Member Author

Lee-W commented Aug 29, 2023

There's a mypy error on airflow/providers/amazon/aws/hooks/appflow.py:27, which is not changed in this PR. Is there I can do to fix this?

@potiuk
Copy link
Member

potiuk commented Aug 29, 2023

This is because your PR generally changes dependencies and it means that it triggers eager upgrade - which means that we had to resolve and find new set of dependencies that your new dependencies and Airflow in general sees as consistent set of dependencies.

Generally follow the advice and attempt to fix it:

image

The thing is that another dependency that is being upgraded adds extra information or changes the definition of the other thing that causes mypy to see it as an issue.

The best way to fix it is to figure out how to fix it and submit a separate PR to fix it and then rebase your PR. Or you can wait until someone else fixes it. This what happens now with main builds (canary builds) - see here:

https://github.com/apache/airflow/actions/runs/6011017073/job/16304198261

Whoever fixes it - fixes it for the others as well. The fastest way to deal with it is to fix it yourself.

@potiuk
Copy link
Member

potiuk commented Aug 29, 2023

Looks like @Taragolis was the first one to fix it #33881

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch 4 times, most recently from ec32d41 to bee2c43 Compare August 30, 2023 05:02
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch from bee2c43 to b964935 Compare August 30, 2023 07:20
@Lee-W
Copy link
Member Author

Lee-W commented Aug 30, 2023

Thanks! I couldn't reproduce it locally yesterday and thus feel a bit confused. I'll take a deeper look next time.

@pankajastro pankajastro merged commit 23b15e6 into apache:main Aug 30, 2023
64 checks passed
@pankajastro pankajastro deleted the add-DefaultAzureCredential-support-to-AzureContainerVolumeHook branch August 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants