Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E731: replace lambda by a def method in Airflow core #33758

Merged
merged 1 commit into from
Aug 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/cli/cli_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ def add_to_parser(self, parser: argparse.ArgumentParser):
"""Add this argument to an ArgumentParser."""
if "metavar" in self.kwargs and "type" not in self.kwargs:
if self.kwargs["metavar"] == "DIRPATH":
type = lambda x: self._is_valid_directory(parser, x)

def type(x):
return self._is_valid_directory(parser, x)

self.kwargs["type"] = type
parser.add_argument(*self.flags, **self.kwargs)

Expand Down
5 changes: 4 additions & 1 deletion airflow/cli/commands/connection_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def create_default_connections(args):

def _format_connections(conns: list[Connection], file_format: str, serialization_format: str) -> str:
if serialization_format == "json":
serializer_func = lambda x: json.dumps(_connection_to_dict(x))

def serializer_func(x):
return json.dumps(_connection_to_dict(x))

elif serialization_format == "uri":
serializer_func = Connection.get_uri
else:
Expand Down
10 changes: 8 additions & 2 deletions airflow/www/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,15 @@ def dag_to_grid(dag: DagModel, dag_runs: Sequence[DagRun], session: Session):

sort_order = conf.get("webserver", "grid_view_sorting_order", fallback="topological")
if sort_order == "topological":
sort_children_fn = lambda task_group: task_group.topological_sort()

def sort_children_fn(task_group):
return task_group.topological_sort()

elif sort_order == "hierarchical_alphabetical":
sort_children_fn = lambda task_group: task_group.hierarchical_alphabetical_sort()

def sort_children_fn(task_group):
return task_group.hierarchical_alphabetical_sort()

else:
raise AirflowConfigException(f"Unsupported grid_view_sorting_order: {sort_order}")

Expand Down