-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve modules import in Airflow providers by some of them into a type-checking block #33754
Conversation
I wish we had other mechanism for that :) |
BTW. This calls for automation and pre-commit. I think we should be able to have an AST pre-commit to verify if an import is only used in Type Hints (and ask to move them to |
I will add some pre-commits after merging the different PRs. I already prepared some of them including this one. |
I figured you are not doing it manually :) |
I will try to split it in smaller PRs starting with the bigger providers (k8S, AWS, GCP, ...). |
9a686c4
to
34c87ba
Compare
I created:
and I kept this one for the rest. |
Providers are safe to merge since we do not cherry-pick them. |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.