-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sql_hook_params
parameter to S3ToSqlOperator
#33427
Conversation
@uranusjr This PR retains how |
2c5f979
to
f4b0838
Compare
sql_hook_params
parameter to S3ToSqlOperator
f4b0838
to
28d191d
Compare
Adding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook. This uses the same "sql_hook_params" parameter name as already used in `SqlToSlackOperator`.
28d191d
to
dbe29a3
Compare
@uranusjr I corrected the test to access the hook using the changed method of getting it from |
Please remove area:core-operators label from this PR as it no longer changes the core operators |
Adding
sql_hook_params
parameter toSqlToS3Operator
. This will allow you to pass extra config params to the underlying SQL hook.This uses the same "sql_hook_params" parameter name as already used in
SqlToSlackOperator
.(This is related to #33425 which adds
sql_hook_params
to the opposite transfer,SqlToS3Operator
)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.