Add helpers to better handle session in tests #33307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
potiuk
added
the
full tests needed
In various places we intentionally create dangling sessions in the worker, but when running a task in tests (which don't use workers) we need to make those not dangling.
uranusjr
force-pushed
the
no-leak-session-in-tests
branch
from
5887049 to
d4933a2
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
@potiuk I forgot the context on this, is this still needed after we have the cleanup context manager thing? |
github-actions
bot
removed
the
stale
|
No. No need. We are now (for a long time) closing all Sqlalchemy sessions between tests, so this is not needed even without context manager I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In various places we intentionally create dangling sessions in the worker, but when running a task in tests (which don't use workers) we need to make those not dangling.