Fix flaky sqlite tests with test_xcom_map_nest hopefully
#33145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently sqlite started to fail randomly during teardown of `test_xcom_map_nest` or `test_xcom_map_zip_nest`. This happpened after adding `test_xcom_map_zip_nest` . It looked very strange: ``` sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread ``` By analysing possible reasons it seems that it was a side effect of the existing `test_xcom_map_nest` that allocated a new session in the run method of task instance rather than pass the sesion that is created and torrn down in the pytest fixture. The hypothesis is that the session created in the ``test_xcom_map_nest`` were being reclaimed and closed while the `test_xcom_map_zip_nest` test was already starting in a different thread started by Pytest. The fix is to pass the session object to run method of the taskinstance in the ``test_xcom_map_nest`` test.
|
Hey @uranusjr -> I think I found the reason of the |
potiuk
requested review from
hussein-awala,
ephraimbuddy,
dstandish and
eladkal
|
Example flaky tests:
|
Yeah.... Let's see if it helps, but looks plausible. |
|
Also add it to 2.7.0 in the hopes it will stabilize the tests there. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 6, 2023
Similarly to apache#33145 - this is an attempt to stabilise flaky tests for the test_xcom_arg_map. Even if the mechanism is not entirely clear (provide_session should also close the connection) seems like using pytest-fixture provided session works better than relying on a new session created in run() methods.
potiuk
added a commit
that referenced
this pull request
Aug 6, 2023
Similarly to #33145 - this is an attempt to stabilise flaky tests for the test_xcom_arg_map. Even if the mechanism is not entirely clear (provide_session should also close the connection) seems like using pytest-fixture provided session works better than relying on a new session created in run() methods.
1 task
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 8, 2023
Similarly to #33145 - this is an attempt to stabilise flaky tests for the test_xcom_arg_map. Even if the mechanism is not entirely clear (provide_session should also close the connection) seems like using pytest-fixture provided session works better than relying on a new session created in run() methods. (cherry picked from commit 3dd0c99)
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 9, 2023
Recently sqlite started to fail randomly during teardown of `test_xcom_map_nest` or `test_xcom_map_zip_nest`. This happpened after adding `test_xcom_map_zip_nest` . It looked very strange: ``` sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread ``` By analysing possible reasons it seems that it was a side effect of the existing `test_xcom_map_nest` that allocated a new session in the run method of task instance rather than pass the sesion that is created and torrn down in the pytest fixture. The hypothesis is that the session created in the ``test_xcom_map_nest`` were being reclaimed and closed while the `test_xcom_map_zip_nest` test was already starting in a different thread started by Pytest. The fix is to pass the session object to run method of the taskinstance in the ``test_xcom_map_nest`` test. (cherry picked from commit d1d6fc9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently sqlite started to fail randomly during teardown of
test_xcom_map_nestortest_xcom_map_zip_nest.It looks very strange:
By analysing possible reasons it seems that it was a side effect of the existing
test_xcom_map_nestthat allocated a new session in the run method of task instance rather than pass the sesion that is created and torrn down in the pytest fixture.The hypothesis is that the session created in the
test_xcom_map_nestwere being reclaimed and closed while thetest_xcom_map_zip_nesttest was already starting in a different thread started by Pytest.The fix is to pass the session object to run method of the taskinstance in the
test_xcom_map_nesttest.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.