-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow templating webserver ingress hostnames #33142
Allow templating webserver ingress hostnames #33142
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Sounds good - can you please add test for it? |
Ok, I'll add test with pytest in https://github.com/apache/airflow/blob/main/helm_tests/webserver/test_ingress_web.py |
4ff3ee7
to
f909443
Compare
9f3ac64
to
3e7618d
Compare
3e7618d
to
c645d8e
Compare
90a650a
to
d79f5e8
Compare
d79f5e8
to
c3b3ea9
Compare
@potiuk I added test cases as requested! |
I'm a bit late! I opened #33384 to change the used function. |
And merged :) |
I would like to propose allowing template values to webserver ingress hostnames.
Why is it needed?
Let's assume that we're providing airflow service to multiple teams.
By creating webserver ingress hostnames using
{{ .Release.Namespace }}
or{{ .Release.Name }}
,there is no need to create multiple values files to store different hostnames for each team.
Usage