Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAG-level permissions disappearance on DAG sync #32999

Closed

Conversation

TruthIsNear
Copy link

Closes: #32839

Adds back the code that was removed in #30340


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 1, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Aug 1, 2023

How does this affect the issue #30340 is supposed to solve?

Also cc @huymq1710

@TruthIsNear
Copy link
Author

How does this affect the issue #30340 is supposed to solve?

Seems like this PR does introduce that issue back

@potiuk potiuk added this to the Airflow 2.7.0 milestone Aug 6, 2023
@potiuk potiuk force-pushed the fix-dag-sync-permissions branch from 9907c05 to 22f680e Compare August 6, 2023 13:19
@potiuk
Copy link
Member

potiuk commented Aug 6, 2023

I rebased it and marked is as 2.7.0. Indeed the #30340 removed syncing where it was still needed and reverting the change seems to solve the problem.

I think this is a blocker for people who use it and want to migrate so having it fixed in 2.7.0 would be great.

@potiuk
Copy link
Member

potiuk commented Aug 6, 2023

I am not sure however if that one is just a band-aid.

Can someone - who knows how the logic of dag permissions syncing was supposed to work? I would like to understand it, because it seems that almost no-one knows how it should work and it is certainly not documented. A slimple logical description of what should happen here might be very useful. I am hppy to take a closer look and try to do it properly. but I need some guidance. I've never touched this part of code and it's a bit of mystery for me on how it should work - but I ema willing to learn @kaxil @jedcunningham @uranusjr. Maybe a birds eye view on that one ??

I think we dropped a ball on that one for 2.6.2 and mostly because we had too little expert knowledge there.

@potiuk
Copy link
Member

potiuk commented Aug 24, 2023

I thin @SamWheating #33632 solution is a better solution. Closing this one in favour of it.

@potiuk
Copy link
Member

potiuk commented Aug 24, 2023

Closing in favour of just merged #33632

@potiuk potiuk closed this Aug 24, 2023
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.7.1 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAG-level permissions set in Web UI disappear from roles on DAG sync
4 participants