-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip served logs for non-running task try #32561
Conversation
cc: @dstandish ? |
Looks correct to me |
Co-authored-by: eladkal <[email protected]> (cherry picked from commit 29d5e95)
This has caused a regression in our use case, as we currently store our logs on the worker with a Persistent Volume with a 2 week retention period. Now when looking at a DAG in our configuration with 2 fails and one retry running, logs of tries number 1 and 2 aren't visible. This happens because the current flow doesn't fetch logs from worker for a running task instance when the try number is not the most recent one. Sure, we could refactor to use remotes but I think there is a way of resolving this that works for both use cases. From what I understand the original problem @Khrol had was that they have their logs in remote and then the server sends an "unnecessary" request trying to fetch logs from the worker. This can be also achieved with just checking |
Surely, If you would like to propose a PR for that where it could be discussed, and take a lead on that - that's the best way to move it forward. |
If the task is running but is retried, the previous attempt logs opening tries to go to served logs. But the logs from there can be already moved to remote storage.
We should skip served logs for non-running task try.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.