fix return values on glue operators deferrable mode #31694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
pankajkoti
approved these changes
Jun 4, 2023
Comment on lines
62
to
63
| glue_job_run = await hook.async_job_completion(self.job_name, self.run_id, self.verbose) | ||
| yield TriggerEvent({"status": "success", "message": "Job done", "value": glue_job_run["JobRunId"]}) |
There was a problem hiding this comment.
Isn't glue_job_run["JobRunId"] the same as self.run_id?
Perhaps we could just return that, so no need to fetch the value from the dictionary key.
Upto if you'd like to consider the suggestion :)
There was a problem hiding this comment.
hmm yes you're right :p
vincbeck
approved these changes
Jun 5, 2023
o-nikolas
approved these changes
Jun 5, 2023
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when implementing the glue deferrable operators in #30948 I forgot to match the return value of the
executefunction in the deferrable handler.Fixing that here, so that the behavior stays the same when using the deferrable version.
Also changing error handling to throw right away instead of returning the error in an event, saving unnecessary scheduling work.