Resolving issue where Grid won't un-collapse when Details is collapsed #31561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removing clearSelection when Details is collapsed - making experience uniform when collapsing or uncollapsing Grid or Detaials view
Adaverse
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:dev-tools
area:UI
Adaverse
changed the title
bbovenzi
reviewed
May 26, 2023
airflow/www/static/js/dag/Main.tsx
Outdated
|
|
||
| const detailsPanelKey = "hideDetailsPanel"; | ||
| const minPanelWidth = 300; | ||
| const collapsedWidth = "28px"; |
There was a problem hiding this comment.
This was intentional, to show just one dag run and still navigate around the task instances
There was a problem hiding this comment.
MB. Didn't notice :)
Makes sense.
Reverted! Updated the demo sample above.
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
#31561) * spinner added * fixed static checks * isFetching * isFetching replaced with isLoading * Update CONTRIBUTING.rst * - fix where collapsed Grid won't show up when Details is uncollapsed - removing clearSelection when Details is collapsed - making experience uniform when collapsing or uncollapsing Grid or Detaials view * resize oberserver re-registering when Grid is un-collapsed * reverting 28px to show atleast one (latest) dag run instance (cherry picked from commit 6f86b6c)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
#31561) * spinner added * fixed static checks * isFetching * isFetching replaced with isLoading * Update CONTRIBUTING.rst * - fix where collapsed Grid won't show up when Details is uncollapsed - removing clearSelection when Details is collapsed - making experience uniform when collapsing or uncollapsing Grid or Detaials view * resize oberserver re-registering when Grid is un-collapsed * reverting 28px to show atleast one (latest) dag run instance (cherry picked from commit 6f86b6c)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is the issue
Grid.does.not.uncollapse.mp4
Below is the fix -
Solved.mp4
updated -
updates.mp4
I have also made a few more changes to enhance user experience -
Made the horizontal divider behaviors exactly the same with Grid and Details interaction.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.