Use keyword paramaters for migration methods for mssql #31309
Conversation
potiuk
added
the
full tests needed
potiuk
force-pushed
the
keyword-parameters-for-mssql-migrations
branch
from
460c661 to
7287c11
Compare
The new alembic (1.11.0) requires parameters to be keyword parameters in methods used in migrations. Part of the problem has been fixed in apache#31306 and apache#31302 but still some migrations that are specifically run in case of mssql need to use migration parameters.
potiuk
force-pushed
the
keyword-parameters-for-mssql-migrations
branch
from
7287c11 to
ea1220d
Compare
| # This file can be modified if you want to make sure the CI build is using "upgrade to newer dependencies" | ||
| # Which is useful when you want to check if the dependencies are still compatible with the latest versions | ||
| # And they seem to break some unrelated tests in main. You can modify this number = 00001 to trigger it. |
There was a problem hiding this comment.
| # This file can be modified if you want to make sure the CI build is using "upgrade to newer dependencies" | |
| # Which is useful when you want to check if the dependencies are still compatible with the latest versions | |
| # And they seem to break some unrelated tests in main. You can modify this number = 00001 to trigger it. | |
| # This file can be modified if you want to make sure the CI build is using "upgrade to newer dependencies", | |
| # which is useful when you want to check if the dependencies are still compatible with the latest versions | |
| # as they seem to break some unrelated tests in main. You can modify this number = 00001 to trigger it. |
There was a problem hiding this comment.
also which number can be modified to 00001 we meant here?
There was a problem hiding this comment.
ohh I guess I understood now what was meant here after reading the Slack message. Will it make sense to rephrase this to somewhat like the following?
To make sure the CI build is using "upgrade to newer dependencies", which is useful when you want to check if the dependencies are still compatible with the latest versions as they seem to break some unrelated tests in main, you can modify this file. The modification can be simply modifying this particular comment. e.g. you can modify the following number 00001 to something else to trigger this.
There was a problem hiding this comment.
Ah. Have not seen the comment> this number (i.e. 00001) can be modified. But if you think you can describe it better - feel free.
There was a problem hiding this comment.
Basically any change to setup.py will do - even adding a space.
There was a problem hiding this comment.
yeah, GitHub is acting weird, my comments are going late. Earlier I tried to merge a couple of PRs and I felt I did but realised now that they were not merged :(
There was a problem hiding this comment.
Tried to rephrase it here: #31312
There was a problem hiding this comment.
I think this time I simply did not refresh the PR. I wanted to merge it fast to fix main so I missed it :)
Following up on my late comment in PR apache#31309, this is a try to rephrase the comment in `setup.py` which indicates how to trigger CI build to use "upgrade to newer dependencies".
Following up on my late comment in PR #31309, this is a try to rephrase the comment in `setup.py` which indicates how to trigger CI build to use "upgrade to newer dependencies".
The new alembic (1.11.0) requires parameters to be keyword parameters in methods used in migrations. Part of the problem has been fixed in #31306 and #31302 but still some migrations that are specifically run in case of mssql need to use migration parameters.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.