Added spinner activity while the logs load #31165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
bbovenzi
requested changes
May 10, 2023
| <LogBlock | ||
| parsedLogs={parsedLogs} | ||
| wrap={wrap} | ||
| tryNumber={taskTryNumber} | ||
| /> | ||
| ) : ( | ||
| <Spinner /> |
There was a problem hiding this comment.
Let's get the loading state from the query to determine when to show the spinner.
const { data, isLoading } = useTaskLog()
There was a problem hiding this comment.
Changes done. Since isLoading is always false in the above case because of the placeholder in the query. Hence, using isFetching for the spinner.
There was a problem hiding this comment.
Actually, we can get rid of that placeholderData and use isLoading normally. isFetching can be true when there is still data to show.
bbovenzi
approved these changes
May 10, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
* spinner added * fixed static checks * isFetching * isFetching replaced with isLoading (cherry picked from commit 584a9f5)
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous -
tutorial - Grid - Airflow (1).webm
tutorial.-.Grid.-.Airflow.mp4
Now -
tutorial.-.Grid.-.Airflow.1.mp4
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.