-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Add Cluster Activity Page #31123
UI Add Cluster Activity Page #31123
Conversation
This looks great! Kudos! Couple of ideas to consider:
|
Whoa . This is going to be incredibly useful! I think especially if it could focus on Airflow-specific charts and graphs, surfacing some common problems people might have. Also a small idea sparked from those chart. How about those (way in the future) with some guidance on how to approach seeing some of those values ! Think of the instructions for your appliance: If you see 3 blinking dots, it likely means that problem and you can approach it possibly by cleaning your ... (half-joking of course, but I think there are a number o things that are petty repeatably fixable problems in Airflow if you could surface some problems in forms of similar charts and people would have some instructions next to those charts. There is a long way from the charts to such instructions, but I think they are an absolute prerequisite and extremely useful on its own. |
4082c9d
to
5de5200
Compare
Thank you for the feedbacks and early reviews, I updated the PR. I implemented everything I could that didn't required too much effort as the change is already considerably big. I would be glad to add more complex features in follow up PRs. Screenshots have been updated :) |
I gathered some feedback from the community (probably ideas for future work)
|
Thank you for the valuable feedback and ideas.
Done for all the pie charts. For the Pool bar chart, ordering in the same way is not straight forward, it's a little trickier. (success is missing from one pool, but exists on another pool, etc). But the overflow might never happen for the pool as the graph is really big. I will still try to implement though, I'll let you know.
Nice, I would be glad to work on those in follow up PRs. |
67e6e59
to
0dd594b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brent, I will update soon. Yes I saw that @pankajkoti added the triggerer health in the API response #31529. I will add it to the dashboard as well. After that we can remove the banner I think |
airflow/www/static/js/cluster-activity/live-metrics/DagRuns.tsx
Outdated
Show resolved
Hide resolved
airflow/www/static/js/cluster-activity/live-metrics/DagRuns.tsx
Outdated
Show resolved
Hide resolved
0dd594b
to
811160b
Compare
@jedcunningham This is how it looks like now, thanks |
b4bfd2a
to
5de0f7a
Compare
#protm |
@pierrejeambrun that's amazing 🤩🤩🤩🤩 |
Thanks @marclamberti, hope users will like it :) |
Great PR, well done @pierrejeambrun 👏 |
This looks amazing @pierrejeambrun, very well done! |
Whoaaaaaa... |
@pierrejeambrun I really like the PR and the newly added page! I just updated my latest master and realize that the menu etry is added in top menu as second entry, so quite present. Was there a discussion about how to place it? Would it be okay if I open a PR to move the menu entry? |
I think the current location is OK. I suggest to wait after 2.7.0 is released. Gather user feedback and then make changes if needed. |
closes: #16081
This add a native dashboard page to the UI to gather a few useful metrics to monitor your airflow cluster.
Up to now people had to build their own dashboard with third parties tools such as grafana.
This PR is not finalized yet but aim to gather feedback on the general structure, UI or any other improvement you might want to see in this page before I go ahead and move forward with a more complete implementation.
TODO:
STATE_COLORS
and Chakra theme / harmonize the paletteMemoize options if needed(no gain identified)