Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the error message for invalid use of poke-only sensors #30821

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

dakshin-k
Copy link
Contributor

Update the error message in the assertion thrown when there's an attempt to change the mode of a poke-only sensor.

A minor change, but it's something that caused me to do a double-take while writing a DAG. So thought I'd submit a patch 😄

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Apr 23, 2023
@dakshin-k dakshin-k force-pushed the poke-only-sensor-error-message branch from 87360a6 to 27239b8 Compare April 23, 2023 07:11
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this error message needs to be clarified.

@hussein-awala hussein-awala added the type:improvement Changelog: Improvements label Apr 23, 2023
@hussein-awala hussein-awala added this to the Airflow 2.6.0 milestone Apr 23, 2023
@potiuk potiuk merged commit cbaea57 into apache:main Apr 23, 2023
@dakshin-k dakshin-k deleted the poke-only-sensor-error-message branch April 23, 2023 13:00
ephraimbuddy pushed a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants