Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to BatchSensor #30279

Merged
merged 15 commits into from
Jun 14, 2023
Merged

Conversation

phanikumv
Copy link
Contributor

@phanikumv phanikumv commented Mar 24, 2023

This PR donates the BatchAsyncSensor from astronomer-providers to Airflow


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@phanikumv phanikumv force-pushed the batch_sensor branch 5 times, most recently from e3c6c54 to 06df4a7 Compare March 31, 2023 14:32
@phanikumv phanikumv force-pushed the batch_sensor branch 4 times, most recently from 38bae75 to b074358 Compare April 6, 2023 16:52
@phanikumv phanikumv changed the title Add BatchAsyncSensor Add deferrable mode to BatchSensor Apr 6, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 27, 2023
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 28, 2023
@phanikumv phanikumv force-pushed the batch_sensor branch 4 times, most recently from dbe77f6 to 5cf180e Compare May 30, 2023 15:43
@phanikumv phanikumv marked this pull request as ready for review May 30, 2023 15:43
@phanikumv phanikumv marked this pull request as draft May 30, 2023 15:48
@phanikumv phanikumv marked this pull request as ready for review May 30, 2023 15:52
@phanikumv phanikumv force-pushed the batch_sensor branch 2 times, most recently from e897a44 to 3f672e2 Compare June 5, 2023 10:09
@phanikumv
Copy link
Contributor Author

Tests/static checks are failing.

this is fixed

@phanikumv phanikumv force-pushed the batch_sensor branch 3 times, most recently from 17cb181 to cdb741a Compare June 8, 2023 13:15
Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankajastro pankajastro merged commit 688f91b into apache:main Jun 14, 2023
@pankajastro pankajastro deleted the batch_sensor branch June 14, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants