Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't separate setup/teardowns from normal task #30008

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

jedcunningham
Copy link
Member

Instead of keeping setup and teardown tasks separate from the normal task list in Task Groups, we will put them all into children together. Attributes on the tasks are all we need to support the setup/teardowns feature, and keeping them as normal-task-like as possible is desirable.

Instead of keeping setup and teardown tasks separate from the normal
task list in Task Groups, we will put them all into children together.
Attributes on the tasks are all we need to support the setup/teardowns
feature, and keeping them as normal-task-like as possible is desirable.
@jedcunningham jedcunningham requested review from kaxil and ashb as code owners March 9, 2023 23:10
@jedcunningham jedcunningham added AIP-52 Automatic setup and teardown tasks and removed area:serialization labels Mar 9, 2023
@uranusjr
Copy link
Member

Are there existing usages of children in the code base that we may need to change?

@jedcunningham
Copy link
Member Author

We are already touching most (all?) of the sections that might care, like the graph, clearing behavior, and trigger rules. I don't know of other instances that will need to change.

@jedcunningham jedcunningham merged commit 275ef6c into apache:main Mar 10, 2023
@jedcunningham jedcunningham deleted the dont_split_setup_teardown branch March 10, 2023 23:16
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Mar 22, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-52 Automatic setup and teardown tasks changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants