-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling project location param on async BigQuery dts trigger #29786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Google (including GCP) related issues
labels
Feb 27, 2023
static tests are failing :( |
I guess this was a just random failure.. [error log]
|
potiuk
force-pushed
the
fix/bigquery_dts
branch
from
March 12, 2023 18:42
90e661d
to
cdde11a
Compare
I rebased it. It was a strange error. |
@MrGeorgeOwl - can you take a look please? |
potiuk
approved these changes
Mar 15, 2023
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX FOR THE MR: #27833
1) Handling project location param on async BigQuery dts trigger
Currently, async version of BigQuery dts operator with trigger cannot be used in other regions except us (default) region.
when I used it on another region, trigger task raise error like below.
I added config param in order to cover all the gcp locations.
2) convert type of field
seconds
to int, if it was strrequested_run_time
is in thetemplate_fields
ofBigQueryDataTransferServiceStartTransferRunsOperator
.but google python sdk client needs it to be
int
type. so it must be converted toint
type after task is executed.