DAG list sorting lost when switching page #29756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
2 tasks
There was a problem hiding this comment.
You need to test your feature locally before sending that for a review as 'ready to merge' so you are sure this actually solves the problem. You can take a look at these guides to setup your local environment for development:
- https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst
- https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst
If the PR is not ready you can mark is a 'draft' while waiting for feedback.
For this particular case, you can take a look at one specific query param that we are handling, for instance 'search' and look how it's done.
(generate_pages now takes those 2 extra args but do nothing with them, look at get_params).
amoghrajesh
changed the title
amoghrajesh
requested review from
pierrejeambrun
and removed request for
ryanahamilton,
ashb and
bbovenzi
|
Looking better!
|
|
Thank you for the review @bbovenzi |
uranusjr
reviewed
Mar 2, 2023
uranusjr
approved these changes
Mar 2, 2023
bbovenzi
approved these changes
Mar 2, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Adding sorting keys to generate_pages * Handling review comments and using the new keys * Fixing Brent review comments * Adding docstring --------- Co-authored-by: Amogh <[email protected]> (cherry picked from commit c8cd90f)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Adding sorting keys to generate_pages * Handling review comments and using the new keys * Fixing Brent review comments * Adding docstring --------- Co-authored-by: Amogh <[email protected]> (cherry picked from commit c8cd90f)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dag list sorting order is lost on changing the pages. We should persist the key across pagination
closes: #29322
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.