-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Liveness/Readiness Probe timeouts configurable for PgBouncer Exporter #29752
Make Liveness/Readiness Probe timeouts configurable for PgBouncer Exporter #29752
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
chart/values.schema.json
Outdated
}, | ||
"periodSeconds": { | ||
"description": "Metrics Exporter liveness probe frequency", | ||
"format": "int32", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does helm honor these formats? We don't have them for anything else, and the one instance of it for periodSeconds in the upstream k8s schema has this as int64.
I'd be inclined to just remove all the formats you are adding here, unless you are sure helm actually checks them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it again and pretty agree that it's quite extra to be here. Removed format fields, thank you!
Awesome work, congrats on your first merged pull request! |
Thanks @nuclear0wl! Congrats on your first commit 🎉 |
Closes: #28891
The Pull Request makes Timeouts of Liveness and Readiness Probes for PgBouncer Metrics Exporter configurable. This change allows to provide more stability because it may be necessary to adjust these timeouts in slow environments where it takes more time to execute probes and avoid unnecessary container restarts and failures of Airflow tasks due to the unreachable PgBouncer.