Don't overwrite connection extra with invalid json #27142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If invalid json is provided for a connection's extra, don't actually overwrite it with the invalid data. This matches the intended behavior, based on the flash message we show the user.
jedcunningham
requested review from
uranusjr,
ephraimbuddy,
dstandish and
eladkal
jedcunningham
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
ephraimbuddy
approved these changes
Oct 19, 2022
dstandish
approved these changes
Oct 19, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 19, 2022
If invalid json is provided for a connection's extra, don't actually overwrite it with the invalid data. This matches the intended behavior, based on the flash message we show the user. (cherry picked from commit fece7f0)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If invalid json is provided for a connection's extra, don't actually overwrite it with the invalid data. This matches the intended behavior, based on the flash message we show the user.