-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about JSON Connection format for AWS SSM Parameter Store Secrets Backend #27134
Conversation
|
||
In some cases, URI's you will need stored in Secrets Manager may not be intuitive, for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this: | ||
In some cases, URI's you will need stored in AWS SSM Parameter Store may not be intuitive, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it me or the sentence In some cases, URI's you will need stored in AWS SSM Parameter Store may not be intuitive
does not make a lot of sense ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point to change it. If it confuse you than it might confuse others.
From my side I've just change "Secrets Manager" to "AWS SSM Parameter Store" and split long line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I would make it even simpler.
In some cases, URIs stored in AWS SSM Parameter Store may not be intuitive,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that initial author tried to highlight that Airflow connection URI not a specific connection URI.
E.g. user expected that HTTP https://example.org/path
would work however in Airflow we should use http://https%3A%2F%2Fexample.org%2Fpath
There is also a link to example how to generate URI exists in current doc: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#generating-connection-uri
a9ac812
to
096a8ea
Compare
docs/apache-airflow-providers-amazon/secrets-backends/aws-ssm-parameter-store.rst
Outdated
Show resolved
Hide resolved
096a8ea
to
52b20f9
Compare
Any more comments here :) ? |
52b20f9
to
7e2cd9d
Compare
I've just add reuse same pytest parameters in different tests cases |
82da4bb
to
d3d4c49
Compare
d3d4c49
to
d9379e8
Compare
…ore Secrets Backend (apache#27134)
Since Airflow 2.3 Connection could be represented as JSON object which perfectly work without any changes in
SystemsManagerParameterStoreBackend.get_conn_value
SystemsManagerParameterStoreBackend.get_conn_uri
so it return always URI even if it stored as JSON objects. I do not know but might be better just remove this method since it should not use internally in Airflow since 2.3 however it might use in some user code.